Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stackable-versioned): Add collision check for renamed fields #804

Merged
merged 14 commits into from
Jun 18, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jun 6, 2024

Tracked by stackabletech/issues#507

This PR adds a check to ensure that renamed fields don't collide in any of the declared versions. This is currently not ensured and can lead to two or more fields using the same name in a particular version.

@Techassi Techassi self-assigned this Jun 6, 2024
@Techassi Techassi marked this pull request as ready for review June 14, 2024 13:40
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit d0ab773 Jun 18, 2024
17 checks passed
@Techassi Techassi deleted the feat/crd-versioning-validate-renames branch June 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants