Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: type popups on .tsx files imported from github repo #56

Closed
ntucker opened this issue May 21, 2021 · 2 comments
Closed

BUG: type popups on .tsx files imported from github repo #56

ntucker opened this issue May 21, 2021 · 2 comments
Labels
bug Something isn't working monaco tracked

Comments

@ntucker
Copy link

ntucker commented May 21, 2021


name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''


Describe the bug
Typescript types highlighting works on the *.ts files, but the *.tsx files it does not. I thought it might be due to use of linaria, but even non-linaria .tsx files there is no highlighting.

Link to the blitz that caused the error
https://stackblitz.com/edit/github-8auner?file=src%2FBoundary.tsx

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/github-8auner?file=src%2FBoundary.tsx
  2. Hover over 'children' variable

Expected behavior
Hover context popup with its type

Version of webcontainer
Hash: 7286dbe8d47d3473cde7be488b7d048fb59b05f2

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
Browser name = Chrome
Full version = 90.0.4430.212
Major version = 90
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36
performance.memory = {
totalJSHeapSize: 159765627,
usedJSHeapSize: 156720619,
jsHeapSizeLimit: 4294705152
}

Additional context
Add any other context about the problem here.

@ntucker ntucker changed the title BUG: no syntax highlighting on .tsx files imported from github repo BUG: type popups on .tsx files imported from github repo May 23, 2021
@KwintenP
Copy link
Contributor

Hi!

🙏 for reporting. This does seem like a bug on our end!

@KwintenP KwintenP added bug Something isn't working monaco tracked labels May 25, 2021
@SamVerschueren
Copy link
Contributor

@ntucker The tsx type issue is fixed and it now gives proper intellisense and auto complete.

For your example in particular I did notice an other issue though. We currently run with the TypeScript 4.0 services, and for this it apparently needs TypeScript 4.1 at least. We have an internal ticket to track the upgrade of TypeScript on our end.

image

Closing this as the original issue was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working monaco tracked
Projects
None yet
Development

No branches or pull requests

3 participants