Setup CircleCI project #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR solves issue #5
JoseLion
force-pushed
the
add-continuous-integration
branch
from
8c6da9a
to
88c28ad
Compare
juanpaucar
reviewed
Aug 21, 2020
| - run: | ||
| name: Install Yarn | ||
| command: | | ||
| curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.22.4 |
There was a problem hiding this comment.
Would it be better if we always use the latest version?
There was a problem hiding this comment.
If we do so, CI may fail unexpectedly because we have an engine constraint in the package.json (here).
That helps to avoid inconsistencies in the yarn.lock between team members, so maybe it's better to have a more deterministic version, what do you think? 🙂
PS: version 1.22.4 is the latest stable version of Classic Yarn 😁
juanpaucar
approved these changes
Aug 21, 2020
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5