-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform error should not kill build #48
Comments
Hmm, I think maybe this issue is a bit different. I get the error even when my path is correct |
D'oh! I'm a tool. I was using |
I've noticed some other errors like #49 are killing the build, so I will re-open this issue since it's mostly about not killing the build on errors. 😄 |
Ah yes, you're fully right I'll make sure #49 emits an error (let's see if it can be tested properly ^^) Thanks for raising! |
Cool, so I've created patch for this that should at least catch this particular error - I feel some refactoring might be in place to make this more solid. I'll upload it once I get home because I'm silly and don't have a VPN that can circumvent cafe firewall 😕 haha |
Should be resolved in #52 (mostly, I hope we're not accidentally throwing for more runtime errors - hah) Thanks! |
Getting this when using an invalid filename to sheetify function:
And it kills budo and other tools. Instead, might be better for the transform to emit an
error
event so budo and similar tools can catch it and display this error in the browser.The text was updated successfully, but these errors were encountered: