Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better s-card hover states #90

Closed
hellohynes opened this issue Aug 2, 2018 · 1 comment
Closed

Better s-card hover states #90

hellohynes opened this issue Aug 2, 2018 · 1 comment

Comments

@hellohynes
Copy link
Contributor

Initially posted by Piper in the Stacks Slack room:

I have some concerns regarding .s-card. The hover state on the cards isn’t very recognizable. I’m not really sure why a card wouldn’t need an obvious hover state, to be honest. It either needs a hover state (and should be obvious) or it doesn’t.

Anywho, I ran into the cards on this page a couple weeks ago and was excited that there seemed to be some sort of alternate option for cards that needed a more obvious hover state:
https://stackoverflow.com/jobs/salary/results?l=Columbus%2c+OH%2c+United+States&ed=0&ex=2&ff=1&dr%5B0%5D=DataScientist&tl%5B0%5D=

I went looking at stacks to find how I could implement the shadow on hover and the way the documentation is written, it seems like I can do such a thing

When applying a .bs-* class with a .s-card component, a :hover style is added to the base .bs-* box shadow.

If the above statement is true, then why would there be a .bs-hover class? Well, I was hoping that it would do what the class says it would do… apply a border-shadow on hover.
But apparently this class is attached to the .bs-* classes, which is silly because the documentation says there already will be a shadow increase on hover.

Basically, I’m asking that you move the .bs-hover be attached to only the .s-card class. I can think of at least 3 situations where this would be useful. Including the example I sent you earlier which is currently using custom CSS to implement the shadow.

@TedGoas TedGoas mentioned this issue Nov 21, 2018
4 tasks
@TedGoas
Copy link
Contributor

TedGoas commented Nov 27, 2018

Addressed here

@TedGoas TedGoas closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants