Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I contribute to the repository with a couple of electron prebuilds I created? #212

Open
flowjo-isaach opened this issue Feb 18, 2021 · 2 comments

Comments

@flowjo-isaach
Copy link

Could I contribute some electron prebuilds for version 4.9? I generated prebuilds for electron versions 8,9, and 10. I was unsuccessful with generating a prebuild for 11 though for some reason.

Attached below are the prebuilds:

gl-v4.9.0-electron-v76-darwin-x64.tar.gz
gl-v4.9.0-electron-v80-darwin-x64.tar.gz
gl-v4.9.0-electron-v82-darwin-x64.tar.gz

@dhritzkiv
Copy link
Member

Hi! Sorry I didn't see this sooner.

We used to have prebuilds for electron a while back, but through an unrelated change, lost them for newer releases.

Thanks for generating these prebuilds and offering to include them in the repo. Unfortunately, as a matter of protocol, for safety's sake, I can't accept these binaries as I can't verify them.

I can look into re-enabling them on the CI builds for the next release(s).


Out of curiosity, how do you use headless-go with electron?

@flowjo-isaach
Copy link
Author

flowjo-isaach commented Mar 1, 2021

Sounds good, thank you!

I'm using headless-gl for server side rendering. It's currently bundled with my Electron app during development out of convenience, but it will eventually be ran on a remote server.

The problem I was having, to those reading this, is my build system (CircleCI) would need to rebuild headless-gl each time it detected a change, since there are no prebuilds for Electron in headless-gl.

To fix this issue, I created a simple script that runs my rendering service separate from Electron rather than having Electron fork it as a child process. By keeping them separate from each other, headless-gl can use a prebuild compatible with my current node version (12).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants