Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rule instances to new table structure #3485

Open
dmjb opened this issue May 31, 2024 · 1 comment
Open

Migrate rule instances to new table structure #3485

dmjb opened this issue May 31, 2024 · 1 comment
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@dmjb
Copy link
Contributor

dmjb commented May 31, 2024

Please describe the enhancement

Rule instances are currently stored as a list of JSON objects which makes querying challenging. Migrate rules over to a dedicated table structure.

Solution Proposal

  1. Define new table
  2. Write rule instances to old and new tables
  3. Migrate old rule instances to new table
  4. Change business logic to use new tables exclusively

Describe alternatives you've considered

No response

Additional context

No response

Acceptance Criteria

No response
dmjb added a commit that referenced this issue May 31, 2024
@dmjb
Dual write rule instances to new and old tables
99f2cc9 
Relates to #3485

Any time a profile is created or updated, write the rule instances to
both the new and old rule instance tables. Mark the entries in the old
tables as migrated so that we skip over them when we run the migration
process.
@dmjb dmjb mentioned this issue May 31, 2024
Merged
10 tasks
dmjb added a commit that referenced this issue Jun 4, 2024
@dmjb
Dual write rule instances to new and old tables
9abefb2 
Relates to #3485

Any time a profile is created or updated, write the rule instances to
both the new and old rule instance tables. Mark the entries in the old
tables as migrated so that we skip over them when we run the migration
process.
dmjb added a commit that referenced this issue Jun 4, 2024
@dmjb
Dual write rule instances to new and old tables
763b0b4 
Relates to #3485

Any time a profile is created or updated, write the rule instances to
both the new and old rule instance tables. Mark the entries in the old
tables as migrated so that we skip over them when we run the migration
process.
dmjb added a commit that referenced this issue Jun 4, 2024
@dmjb
Dual write rule instances to new and old tables
dbca1ab 
Relates to #3485

Any time a profile is created or updated, write the rule instances to
both the new and old rule instance tables. Mark the entries in the old
tables as migrated so that we skip over them when we run the migration
process.
dmjb added a commit that referenced this issue Jun 5, 2024
@dmjb
Dual write rule instances to new and old tables
1aa28e6 
Relates to #3485

Any time a profile is created or updated, write the rule instances to
both the new and old rule instance tables. Mark the entries in the old
tables as migrated so that we skip over them when we run the migration
process.
dmjb added a commit that referenced this issue Jun 5, 2024
@dmjb
Dual write rule instances to new and old tables (#3486)
f170622 
Relates to #3485

Any time a profile is created or updated, write the rule instances to
both the new and old rule instance tables. Mark the entries in the old
tables as migrated so that we skip over them when we run the migration
process.

Also made def/params field nullable.
@evankanderson
Copy link
Member

@dmjb -- did we do this?

@evankanderson evankanderson added P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage and removed user-story labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmjb @evankanderson