Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityInfoWrapper.GetEntityDBIDs() hardcodes an architecture limitation #3838

Open
puerco opened this issue Jul 11, 2024 · 2 comments
Open
Assignees
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@puerco
Copy link
Contributor

puerco commented Jul 11, 2024

The EntityInfoWrapper.GetEntityDBIDs() function returns UUIDs for three specific entity types: repo, artifact, and pull request:

https://github.com/stacklok/minder/blob/e77e1427679fc3b18111cfc565559dc661ab789f/internal/engine/entities/entity_event.go#L252-L255

To expand Minder in the future to handle other entity types we should replace this function and all its invocations with a more flexible alternative to work with any future entity.

@evankanderson
Copy link
Member

@JAORMX -- do you want to "adopt" this as part of your entity rework?

@evankanderson evankanderson added the P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage label Sep 10, 2024
@JAORMX
Copy link
Contributor

JAORMX commented Sep 10, 2024

Oh, this is accidentally being addressed. Yeah, assign it to me. Hopefully by the end of the week this will no longer be an issue.

@JAORMX JAORMX self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Development

No branches or pull requests

3 participants