Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int32 database identifiers are evil! #1028

Merged
merged 1 commit into from
Sep 28, 2023
Merged

int32 database identifiers are evil! #1028

merged 1 commit into from
Sep 28, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 27, 2023

This starts migrating away from that.

@JAORMX JAORMX changed the title int32 database identifiers are evil! int32 database identifiers are evil! Sep 27, 2023
@JAORMX JAORMX force-pushed the int32-to-uuid branch 3 times, most recently from 148a1d4 to cc6c2ff Compare September 27, 2023 10:45
@JAORMX JAORMX requested a review from jhrozek September 27, 2023 10:45
@JAORMX JAORMX changed the title int32 database identifiers are evil! WIP: int32 database identifiers are evil! Sep 27, 2023
@JAORMX JAORMX force-pushed the int32-to-uuid branch 3 times, most recently from 6ec20ba to ca31506 Compare September 27, 2023 11:21
jhrozek
jhrozek reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this work is going and left a bunch of comments since this PR is a WIP.

database/migrations/000001_init.up.sql Show resolved Hide resolved
database/migrations/000001_init.up.sql Show resolved Hide resolved
internal/reconcilers/artifacts.go Show resolved Hide resolved
cmd/cli/app/artifact/artifact_get.go Show resolved Hide resolved
@JAORMX JAORMX changed the title WIP: int32 database identifiers are evil! int32 database identifiers are evil! Sep 28, 2023
@JAORMX
int32 database identifiers are evil!
eedac66 
This starts migrating away from that.
@JAORMX JAORMX requested a review from jhrozek September 28, 2023 07:01
@JAORMX JAORMX merged commit 15caad5 into main Sep 28, 2023
13 checks passed
@JAORMX JAORMX deleted the int32-to-uuid branch September 28, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

@jhrozek jhrozek jhrozek approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JAORMX @jhrozek @rdimitrov