Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove APIs we won't be exposing soon #1149

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 9, 2023

This removes the APIs that we don't intend to expose in the beginning.

Leaving only the minimum necessary things for folks to self-enroll
and for mediator to be useful.

This also removes the tests that are no longer relevant.

Closes: #1141

eleftherias
eleftherias previously approved these changes Oct 9, 2023
This removes the APIs that we don't intend to expose in the beginning.

Leaving only the minimum necessary things for folks to self-enroll
and for mediator to be useful.

This also removes the tests that are no longer relevant.

Closes: #1141
Copy link
Contributor

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good, would it be useful for me to test locally @JAORMX ?

@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 9, 2023

@lukehinds it would be useful

@lukehinds lukehinds merged commit 657d372 into main Oct 9, 2023
13 checks passed
@lukehinds lukehinds deleted the remove-apis branch October 9, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harden domain model (remove all relevant APIs)
3 participants