New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alerts: add create and close github calls for security advisories #1178

Merged

rdimitrov merged 2 commits into mindersec:main from rdimitrov:alerts

Oct 12, 2023

Member

rdimitrov commented Oct 11, 2023

The following PR adds methods for creating and closing a Github security advisory.

Notes:

This will be improved in future by using a github.SecurityAdvisory type which has all the necessary fields once go-github release a new version and we migrate to it. We are at v53, last is v55, so waiting for v56.
Eventually the goal is to replace these completely by using dedicated calls provided by go-github after they are made available (potentially upstreaming these changes?).

rdimitrov added 2 commits

October 12, 2023 00:46


          alerts: add create and close github calls for security advisories

c687bff

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>


          fix: linting errors

3548d13

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>

rdimitrov self-assigned this

JAORMX approved these changes

View reviewed changes

Contributor

JAORMX left a comment

nice and simple

rdimitrov merged commit 0ea1c2b into mindersec:main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet