Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use interfaces for actions and evaluation params #1290

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

rdimitrov
Copy link
Member

The following PR updates the evaluator and the actions engine to use dedicated interfaces for using the eval params.

Fixes #1274

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov self-assigned this Oct 26, 2023
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels much cleaner, thank you. If you want, you can add the interface assertion assignments that I pointed out inline, but it's not a big deal and can be done in another PR if you want to move forward with this one.

evalErr error
actionsErr evalerrors.ActionsError
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add:

var _ ActionsParams = (*EvalStatusParams)(nil)
var _ EvalParams = (*EvalStatusParams)(nil)

@rdimitrov rdimitrov merged commit e6bdc03 into mindersec:main Oct 26, 2023
12 checks passed
@JAORMX JAORMX deleted the iface branch October 26, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: use an interface for getting/setting evalParams values
3 participants