Remove Go ecosystem config from the Pi rule-type #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pi only supports NPM and PyPi (and Rust which we don't support on the Minder side..yet..), so let's not send the Go ecosystem diffs to the evaluator, where they would be silently skipped.
rdimitrov
approved these changes
Oct 30, 2023
JAORMX
approved these changes
Oct 31, 2023
This was referenced Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pi only supports NPM and PyPi (and Rust which we don't support on the
Minder side..yet..), so let's not send the Go ecosystem diffs to the
evaluator, where they would be silently skipped.