Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double the client timeout #1382

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Double the client timeout #1382

merged 1 commit into from
Nov 1, 2023

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Nov 1, 2023

When talking to a remote mediator instance, sometimes the 5 seconds were
not enough. Let's increase the timeout.

Fixes: #1374

When talking to a remote mediator instance, sometimes the 5 seconds were
not enough. Let's increase the timeout.

Fixes: #1374
@jhrozek
Copy link
Contributor Author

jhrozek commented Nov 1, 2023

Flaky test:

❌ TestAll/TestHandleWebHookUnexistentRepoPackage (10ms)
      handlers_githubwebhooks_test.go:384: 
          	Error Trace:	/home/runner/work/mediator/mediator/internal/controlplane/handlers_githubwebhooks_test.go:384
          	Error:      	Received unexpected error:
          	            	Post "http://localhost:44033": dial tcp [::1]:44033: connect: connection refused
          	Test:       	TestAll/TestHandleWebHookUnexistentRepoPackage
          	Messages:   	failed to make request
      controller.go:269: missing call(s) to *mockdb.MockStore.GetRepositoryByRepoID(is anything, is anything) /home/runner/work/mediator/mediator/internal/controlplane/handlers_githubwebhooks_test.go:347
      controller.go:269: aborting test due to missing call(s)

@JAORMX JAORMX merged commit 3ac8f2f into mindersec:main Nov 1, 2023
12 checks passed
@JAORMX JAORMX deleted the client_timeout branch November 1, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the client timeout in general
2 participants