Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ingress annotations configurable #1467

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Make ingress annotations configurable #1467

merged 1 commit into from
Nov 4, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 4, 2023

This enables us to have different settings in prod and staging

This enables us to have different settings in prod and staging
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for anyone following, the values will now be passed from https://github.com/stacklok/infra/pull/279

@JAORMX JAORMX merged commit 75295e8 into main Nov 4, 2023
12 checks passed
@JAORMX JAORMX deleted the ingress-anns branch November 4, 2023 13:38
@evankanderson evankanderson mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants