Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip branch protection remediations for repos with no branches #3035

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 10, 2024

Summary

Comparing the error message for a know string might seem hacky but
go-github does that internally too, so...

Fixes: #1992

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

create an empty repo and apply branch protection rules

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner April 10, 2024 22:33
Comparing the error message for a know string might seem hacky but
go-github does that internally too, so...

Fixes: mindersec#1992
@coveralls
Copy link

coveralls commented Apr 10, 2024

Coverage Status

coverage: 48.221% (-0.02%) from 48.238%
when pulling 5e0bbc8 on jhrozek:no_branch_no_problem
into 68f0b35 on stacklok:main.

@JAORMX JAORMX merged commit 350aa0f into mindersec:main Apr 11, 2024
20 checks passed
dmjb pushed a commit that referenced this pull request Apr 11, 2024
Comparing the error message for a know string might seem hacky but
go-github does that internally too, so...

Fixes: #1992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A fresh repo cannot be remediated with branch protections
4 participants