Only run deletion reconciler on repo deleted events #3036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The trigger for the reconciler was too greedy and would issue deletion events
on more entities than just repos. e.g. when a branch is deleted. This is not ideal.
Instead, this trims down the triggering of the event to just repo deletion events coming from GitHub.
Change Type
Mark the type of change your PR introduces:
Testing
Review Checklist: