Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not post a pr review if no homoglyphs are found #3364

Merged
merged 1 commit into from
May 20, 2024

Conversation

teodor-yanev
Copy link
Contributor

@teodor-yanev teodor-yanev commented May 20, 2024

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

The homoglyphs' prReviewHandler is causing too much noise when leaving a "green check" review after every commit.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Commits in their respective order show that no reviews were posted if no issues are found and vice-versa (posted if issues are found) (the feature was tested on a local server):
teodor-yanev/a-testrepo@df0fad3
teodor-yanev/a-testrepo@7eecb16
teodor-yanev/a-testrepo@f4791e3

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@teodor-yanev teodor-yanev requested a review from a team as a code owner May 20, 2024 06:07
@teodor-yanev teodor-yanev self-assigned this May 20, 2024
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Invisible Unicode Characters Detected.

@teodor-yanev
Copy link
Contributor Author

@JAORMX Thanks for kicking off the job again. 😄

@coveralls
Copy link

Coverage Status

coverage: 50.23% (+0.02%) from 50.206%
when pulling 840055d on update-homoglyphs-pr-handler
into ad49d69 on main.

@teodor-yanev teodor-yanev requested a review from JAORMX May 20, 2024 06:32
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I asked @teodor-yanev to test it out, and after he comes back with results we'll merge this.

@teodor-yanev
Copy link
Contributor Author

My bad for missing out on providing testing evidence.

@JAORMX issue description updated.

@teodor-yanev teodor-yanev merged commit 1ccdb36 into main May 20, 2024
23 checks passed
@teodor-yanev teodor-yanev deleted the update-homoglyphs-pr-handler branch May 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants