Test: fix httpcore test for defaulting in proof query string #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4140 +/- ##
===========================================
+ Coverage 62.42% 67.70% +5.27%
===========================================
Files 401 401
Lines 286383 286383
===========================================
+ Hits 178775 193886 +15111
+ Misses 107608 92497 -15111 ☔ View full report in Codecov by Sentry. |
wileyj
approved these changes
Dec 8, 2023
jferrant
approved these changes
Dec 11, 2023
jcnelson
approved these changes
Dec 11, 2023
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #4139 updated the defaulting proof query string behavior, but didn't update the unit test for that behavior in
net::tests