Fix: RPC endpoints should default to proof=1 #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4139 +/- ##
========================================
Coverage 72.27% 72.28%
========================================
Files 401 401
Lines 286381 286381
========================================
+ Hits 206994 207012 +18
+ Misses 79387 79369 -18 ☔ View full report in Codecov by Sentry. |
jcnelson
approved these changes
Dec 8, 2023
wileyj
approved these changes
Dec 8, 2023
This was referenced Dec 8, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HTTP changes in
developchanged the default behavior of theproofquery string. Inmaster, it defaults to1, but indevelopit defaults to0.I'm open to changing this default, but this is why
tests::integrations::integration_test_get_infobroke, and the change would need to be mentioned specifically in the changelog. I think the right thing to do here is to return to the prior behavior, and if we want to change the default, we can do that in another PR that also updates the tests.