Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist folder not included when installing with bower #39

Closed
GustavSt opened this issue Jul 25, 2016 · 3 comments
Closed

dist folder not included when installing with bower #39

GustavSt opened this issue Jul 25, 2016 · 3 comments

Comments

@GustavSt
Copy link

GustavSt commented Jul 25, 2016

Expected Behavior

When doing bower install stacktrace-gps the dist folder should be included, since the bower.json main property points to the js-file in the dist-folder

Current Behavior

when doing bower install stacktrace-gps there is no dist-folder. There is no folder structure, everything is in the root folder

Context

When using wiredep this package's main file is not automatically injected in my index.html. I'm using stacktrace-js that have this package as a dependency, and the other packages it has as dependency is correctly injected but not this one.

Your Environment

  • stacktrace.js version: 2.3.* and 2.4.*
  • Operating System and version (desktop or mobile): windows 10
  • Bower version: 1.7.9

Possible Solution

Set main to not be dist/{file}.js but just ./{file}.js. I'm not sure why dist folder is not included, could be the ignore of **/.* ? If it is, maybe rethink that part so that dist-folder is included.

@eriwen
Copy link
Member

eriwen commented Dec 12, 2016

Hmm. I'm not able to reproduce this. If I run bower install stacktrace-gps I get the dist/ folder and everything under it. **/.* just excludes .jscsrc and other dotfiles. I'm trying this with stacktrace-gps 2.4.4.

Can you please confirm that you still don't see dist/ with the latest stacktrace-gps?

@GustavSt
Copy link
Author

GustavSt commented Dec 12, 2016

It was a while ago, but when I try and install stacktrace-gps via bower I don't get a dist folder. If I install via npm I do get it. For me it's the same with v 2.4.4 and 2.3.3.

@oliversalzburg
Copy link
Member

Works fine for me.

@eriwen eriwen closed this as completed May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants