-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sourmash LCA database update url? #15
Comments
Hmm, actually I'm not getting any taxonomy results from |
hmm, I 'll try to test myself locally not sure if need to ask for input from @ctb or @luizirber if stuck. |
yeah could just be me -- I haven't tried to use it in a few years. (I'm also on my Mac with sourmash install from BIOCONDA) |
But alternatively we could stick with an older version of sourmash, in case anybody is looking here, commands we are trying to run are:
Using the latest v4.2.2 on Mac OS, I essentially got this result:
|
Ah, I guess I should look at the command help menu!
|
ahh okay. changes to apply. |
hi all, thanks for tagging me in! I'll have to go digging to give you exact dates, but we updated LCA database formats many, many moons ago - back in 2.x somewhere. The difference in results is unexpected. The underlying algorithms didn't change; the database format expanded to accommodate sketches that didn't have taxonomy associated. Last but by no means least, sourmash compute still works as it did before, and the sketch/signature formats are the same. So no change needed there right now. It's just getting removed in 5.0 :). |
Okay thanks @ctb -- must be related to something with my install. I'll try to figure out and open an issue on sourmash GitHub if I can't figure it out. So @hyphaltip no reason to change the way we are running this quite yet, but we will need to update the database/resource link I think. |
well, I doubt it's your install - it's probably some SNAFU on our part, since it should have been working the same as before :). Either that or the database is bad/wrong? Yay computerz. We'll figure it out together tho, promise. I do think you might want to take advantage of the new |
Okay, I'll look into that. Basically what we are trying to do here is just classify each contig from de novo assembly and remove things that are obviously contamination, ie bacterial taxonomic classification when we are working on a fungal genome. |
hi! reminded of this by https://twitter.com/jonpalmer2013/status/1521312530936725506 :) we did just release new databases! it would be easy for me to build you a new Genbank LCA (or give you the commands to do it), or you could just use the GTDB ones. |
(as of sourmash v4.4, scheduled soon, we can also point you at larger-on-disk but much faster and lower memory SQLite-based LCA database.) |
thanks i was trying some thing before and it was way too slow for us to put on but I want to give this another go. Noting that our current 'sourpurg' w sourmash did about as good a job as NCBI's now available screening tool in a fraction of the time and a lot less data to download.. |
k - let us know how we can help! would AAFTF be something we can just download and run on our own, if we feel so inclined to try it out? |
sure - is very simple python package and certainly welcome someone else helping me package it up for conda properly... |
have implemented, it doesn't seem to really work as well as the old genbank-k31 though
With old scheme.
@ctb is this because the gtdb is really bacteria only? I think this is okay in a sense but I guess DBs are too large now to really do a single sourmash search on representative dbs? |
Of course. I can send some directions. It has a test set I can share if it’s not in there now. Not had a lot of dev time lately but this would be easy. There’s a config file with dictionary that sets the download url for the sourmash db.
…On May 5, 2022, 5:10 PM -0700, C. Titus Brown ***@***.***>, wrote:
k - let us know how we can help! would AAFTF be something we can just download and run on our own, if we feel so inclined to try it out?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This has been fixed now, it downloads automatically into $AAFTF_DB (either env variable or cmdline option) to save this DB. There are also options to run against GTDB databases as indexed by sourmash tools of @ctb and @sourmash-bio relying on LCA index files listed https://sourmash.readthedocs.io/en/latest/databases.html#gtdb-r08-rs214-dna-databases in addition the LCA for genbank 2017 which actually works really well for finding bacteria contamination and is fast to search https://sourmash.readthedocs.io/en/latest/legacy-databases.html#genbank-microbial-genomes-lca |
Seems that at some point sourmash newer version requires an updated LCA database, I got failure with v4.2.2 and the one we have pinned in resources.py. New link is https://osf.io/9xdg2/download and page is https://sourmash.readthedocs.io/en/latest/databases.html
The text was updated successfully, but these errors were encountered: