Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Recent CI authored auto-releases are broken! #649

Closed
kakkoyun opened this issue Apr 26, 2024 · 11 comments
Closed

[BUG] Recent CI authored auto-releases are broken! #649

kakkoyun opened this issue Apr 26, 2024 · 11 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@kakkoyun
Copy link

Describe the bug
0838acd

Screenshot 2024-04-26 at 19 27 19

CI introduces an additional v as a prefix.

To Reproduce
helm upgrade

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Failure!

Screenshot 2024-04-26 at 19 27 37

@kakkoyun kakkoyun added the kind/bug Something isn't working label Apr 26, 2024
@karl-johan-grahn
Copy link
Contributor

version: 1.0.85
appVersion: v1.0.85

to

version: v1.0.86
appVersion: vv1.0.86

must have been that version started getting v prefix

@karl-johan-grahn karl-johan-grahn self-assigned this Apr 26, 2024
@karl-johan-grahn
Copy link
Contributor

docs images are pushed with https://github.com/stakater/.github/blob/main/.github/workflows/push_container.yaml which add v by default

@karl-johan-grahn
Copy link
Contributor

we push all images with "v" but when pushing the chart we remove the "v" from the version 🙄

@karl-johan-grahn
Copy link
Contributor

In https://github.com/stakater/Reloader/actions/runs/8851628050/job/24308595322 it is not getting any new commits for some reason so it is not generating the operator tag properly

@karl-johan-grahn
Copy link
Contributor

Rerunning the job to see if it is some flaky behavior of github-tag-action

@karl-johan-grahn
Copy link
Contributor

So on rerun the action correctly generated a new tag:

Bumping tag v1.0.87 - New tag 1.0.88

however then it failed with another push issue so rerunning again

@karl-johan-grahn
Copy link
Contributor

The later failure could be related to #636

@karl-johan-grahn
Copy link
Contributor

The last bump 9a9fee2 went as expected so I will troubleshoot a little more to see under what circumstances we get the v prefix

@kakkoyun
Copy link
Author

Thanks for looking into this ❤️

@karl-johan-grahn
Copy link
Contributor

Yes it's something with the doc workflow that is causing the v prefix to appear d4b7d38

@karl-johan-grahn
Copy link
Contributor

This should be resolved now, it was most probably a race condition where two push workflows ran at the same time:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants