Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom WebSocketClients require manual stop #33

Closed
IGJoshua opened this issue Apr 1, 2020 · 1 comment · Fixed by #35
Closed

Custom WebSocketClients require manual stop #33

IGJoshua opened this issue Apr 1, 2020 · 1 comment · Fixed by #35

Comments

@IGJoshua
Copy link
Contributor

IGJoshua commented Apr 1, 2020

After working with the websockets for a while, I noticed that in order to create a websocket with an adequate buffer size, I have to manually create a websocket client (or use the provided client function from gniazdo), but when I close the websocket, that client isn't stopped. That may be intended behavior, but the result is that it keeps applications alive after all other non-daemon threads have stopped, and it's difficult to determine the reason because it's not mentioned in the documentation.

I'd love to see the documentation related to the client function specify that the client must have .stop called on it in order to exit the application.

@jstepien
Copy link
Collaborator

jstepien commented Apr 1, 2020

Hey, thanks for filing the issue. I'd be happy to merge a patch adjusting the documentation as you outlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants