Update deprecated syntax and fix vignettes #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the diff is a little inflated due to my IDE stripping trailing whitespace, you can see the diff with those filtered out here: https://github.com/stan-dev/rstan/pull/1055/files?w=1 |
andrjohns
force-pushed
the
deprecated-syntax
branch
from
17d24f6
to
68f6255
Compare
|
Obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Stan code used in the examples & vignettes (and some of the demonstrative c++) has since been deprecated or removed. Additionally, the vignettes were failing to build due to some configuration/compilation issues.
The following changes have been made in this PR:
rstanexamples and vignettes updated to remove any deprecated syntaxStanHeaderswas not compilingsundials/sundials_context.cunder unix, leading to ODE linking errors in the vignetteStanHeaders::stanFunction()was not using the package's CXXFLAGS, leading to compilation errors due to the missing-D_REENTRANTunder unix when building the vignetterstanexternal c++ vignette was usingstan::math::precomp_v_vari()which has since been removed