Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loo with k_threshold error for stan_polr #450

Closed
jgabry opened this issue Jul 28, 2020 · 0 comments
Closed

loo with k_threshold error for stan_polr #450

jgabry opened this issue Jul 28, 2020 · 0 comments
Labels

Comments

@jgabry
Copy link
Member

jgabry commented Jul 28, 2020

loo with k_threshold errors for stan_polr because at this line

newz = x$z[omitted, , drop = FALSE], # NULL other than for some stan_betareg models

because of partial matching by $ (x$z partially matches the x$zeta in the object returned by stan_polr). This was initially reported on discourse (https://discourse.mc-stan.org/t/issue-with-loo-with-k-threshold/17052), albeit with a slightly different error message than I was getting.

I'm about to push a fix for this. @bgoodri Did you already submit the rstanarm patch with the stan_aov() fix? If not we should include this, otherwise it can wait until next release.

@jgabry jgabry added the bug label Jul 28, 2020
@jgabry jgabry closed this as completed in 17c5b4a Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant