Bugfix/issue 1179 exponential lower bound check #1469

rtrangucci · 2015-06-01T21:17:11Z

Summary:

Added random variable bounds checking for exponential_log

Intended Effect:

No longer allow exponential_log to be evaluated at a negative value of the random variable

How to Verify:

./runTests.py src/test/prob/exponential/

Side Effects:

None.

Documentation:

None.

Reviewer Suggestions:

Daniel or Bob.

stan-buildbot · 2015-06-02T07:54:22Z

Refer to this link for build results (access rights to CI server needed):
http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/400/

Build Log
last 20 lines

[...truncated 11 lines...]
 > /usr/local/git/bin/git rev-parse refs/remotes/origin/origin/pr/1469/merge^{commit} # timeout=10
Checking out Revision 32844064ebb194dd32f322f3934c2def53d58e37 (refs/remotes/origin/pr/1469/merge)
 > /usr/local/git/bin/git config core.sparsecheckout # timeout=10
 > /usr/local/git/bin/git checkout -f 32844064ebb194dd32f322f3934c2def53d58e37
First time build. Skipping changelog.
Starting build job Stan Pull Request - Doc - Doxygen.
Starting build job Stan Pull Request - Doc - Reference Manual.
Finished Build : #394 of Job : Stan Pull Request - Doc - Reference Manual with status : SUCCESS
Finished Build : #400 of Job : Stan Pull Request - Doc - Doxygen with status : SUCCESS
Starting build job Stan Pull Request - Tests - Integration.
Starting build job Stan Pull Request - Tests - Header.
Starting build job Stan Pull Request - Tests - Unit.
Starting build job Stan Pull Request - Windows - Tests - Unit.
Finished Build : #366 of Job : Stan Pull Request - Tests - Header with status : SUCCESS
Finished Build : #368 of Job : Stan Pull Request - Tests - Integration with status : SUCCESS
Finished Build : #215 of Job : Stan Pull Request - Windows - Tests - Unit with status : FAILURE
Finished Build : #368 of Job : Stan Pull Request - Tests - Unit with status : ABORTED
Build step 'MultiJob Phase' marked build as failure
Setting status of 01a281da4e679d7e08cfcc58fc69067b234102ed to FAILURE with url http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/400/ and message: Build finished.

Test FAILed.

syclik · 2015-06-02T18:09:04Z

Jenkins, retest this please.

stan-buildbot · 2015-06-03T06:54:42Z

Refer to this link for build results (access rights to CI server needed):
http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/403/

Build Log
last 20 lines

[...truncated 20 lines...]
Starting build job Stan Pull Request - Tests - Integration.
Starting build job Stan Pull Request - Tests - Unit.
Starting build job Stan Pull Request - Tests - Header.
Starting build job Stan Pull Request - Windows - Tests - Unit.
Finished Build : #371 of Job : Stan Pull Request - Tests - Integration with status : SUCCESS
Finished Build : #369 of Job : Stan Pull Request - Tests - Header with status : SUCCESS
Finished Build : #371 of Job : Stan Pull Request - Tests - Unit with status : SUCCESS
Finished Build : #218 of Job : Stan Pull Request - Windows - Tests - Unit with status : SUCCESS
Starting build job Stan Pull Request - CppLint.
Starting build job Stan Pull Request - Math Dependencies.
Finished Build : #140 of Job : Stan Pull Request - CppLint with status : SUCCESS
Finished Build : #99 of Job : Stan Pull Request - Math Dependencies with status : SUCCESS
Starting build job Stan Pull Request - Performance.
Finished Build : #118 of Job : Stan Pull Request - Performance with status : SUCCESS
Starting build job Stan Pull Request - Interface - CmdStan.
Finished Build : #101 of Job : Stan Pull Request - Interface - CmdStan with status : FAILURE
Starting build job Stan Pull Request - Distribution Tests.
Finished Build : #216 of Job : Stan Pull Request - Distribution Tests with status : SUCCESS
Setting status of 01a281da4e679d7e08cfcc58fc69067b234102ed to FAILURE with url http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/403/ and message: Build finished.

Test FAILed.

syclik · 2015-06-03T11:26:54Z

The tests are fine. I need to find out why the interface occasionally
fails.

On Wednesday, June 3, 2015, Stan buildbot notifications@github.com wrote:

Refer to this link for build results (access rights to CI server needed):
http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/403/

Build Log
last 20 lines

[...truncated 20 lines...]
Starting build job Stan Pull Request - Tests - Integration.
Starting build job Stan Pull Request - Tests - Unit.
Starting build job Stan Pull Request - Tests - Header.
Starting build job Stan Pull Request - Windows - Tests - Unit.
Finished Build : #371 of Job : Stan Pull Request - Tests - Integration with status : SUCCESS
Finished Build : #369 of Job : Stan Pull Request - Tests - Header with status : SUCCESS
Finished Build : #371 of Job : Stan Pull Request - Tests - Unit with status : SUCCESS
Finished Build : #218 of Job : Stan Pull Request - Windows - Tests - Unit with status : SUCCESS
Starting build job Stan Pull Request - CppLint.
Starting build job Stan Pull Request - Math Dependencies.
Finished Build : #140 of Job : Stan Pull Request - CppLint with status : SUCCESS
Finished Build : #99 of Job : Stan Pull Request - Math Dependencies with status : SUCCESS
Starting build job Stan Pull Request - Performance.
Finished Build : #118 of Job : Stan Pull Request - Performance with status : SUCCESS
Starting build job Stan Pull Request - Interface - CmdStan.
Finished Build : #101 of Job : Stan Pull Request - Interface - CmdStan with status : FAILURE
Starting build job Stan Pull Request - Distribution Tests.
Finished Build : #216 of Job : Stan Pull Request - Distribution Tests with status : SUCCESS
Setting status of 01a281d to FAILURE with url http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/403/ and message: Build finished.

Test FAILed.

—
Reply to this email directly or view it on GitHub
#1469 (comment).

syclik · 2015-06-03T17:49:43Z

src/stan/math/prim/scal/prob/exponential_log.hpp

@@ -69,6 +69,7 @@ namespace stan {

      T_partials_return logp(0.0);
      check_not_nan(function, "Random variable", y);


Remove this check -- it's covered by check_nonnegative

removed check_not_nan

syclik · 2015-06-04T03:55:29Z

@rtrangucci, looks good. Thanks for adding that last test.

syclik · 2015-06-04T16:08:24Z

Jenkins, retest this please.

syclik · 2015-06-04T16:08:31Z

I don't trust that test failure.

stan-buildbot · 2015-06-05T02:37:21Z

Refer to this link for build results (access rights to CI server needed):
http://d1m1s1b1.stat.columbia.edu:8080/job/Stan%20Pull%20Request/406/
Test PASSed.

…lower-bound-check Fixes #1469. Bugfix/issue 1179 exponential lower bound check

rtrangucci added 7 commits May 6, 2015 16:53

Merge branch 'develop' of https://github.com/stan-dev/stan into develop

63271b6

Merge branch 'develop' of https://github.com/stan-dev/stan into develop

56035f9

Merge branch 'develop' of https://github.com/stan-dev/stan into develop

1df6630

Merge branch 'develop' of https://github.com/stan-dev/stan into develop

75bef68

Merge branch 'develop' of https://github.com/stan-dev/stan into develop

2b2c34b

b b/i-1179 added check_nonnegative call on y

8dd47da

b b/i-1179 rm tabs

01a281d

syclik reviewed Jun 3, 2015
View reviewed changes

b f/i-1179 Added valid value test and invalid value test

1b90a57

removed check_not_nan

syclik added this to the v2.7.0 milestone Jun 4, 2015

syclik added the code review complete label Jun 4, 2015

syclik added a commit that referenced this pull request Jun 5, 2015

Merge pull request #1469 from stan-dev/bugfix/issue-1179-exponential-…

7ad520e

…lower-bound-check Fixes #1469. Bugfix/issue 1179 exponential lower bound check

syclik merged commit 7ad520e into develop Jun 5, 2015

syclik deleted the bugfix/issue-1179-exponential-lower-bound-check branch June 5, 2015 03:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/issue 1179 exponential lower bound check #1469

Bugfix/issue 1179 exponential lower bound check #1469

rtrangucci commented Jun 1, 2015

stan-buildbot commented Jun 2, 2015

syclik commented Jun 2, 2015

stan-buildbot commented Jun 3, 2015

syclik commented Jun 3, 2015

syclik Jun 3, 2015

rtrangucci Jun 3, 2015

syclik commented Jun 4, 2015

syclik commented Jun 4, 2015

syclik commented Jun 4, 2015

stan-buildbot commented Jun 5, 2015

		@@ -69,6 +69,7 @@ namespace stan {

		T_partials_return logp(0.0);
		check_not_nan(function, "Random variable", y);

Bugfix/issue 1179 exponential lower bound check #1469

Bugfix/issue 1179 exponential lower bound check #1469

Conversation

rtrangucci commented Jun 1, 2015

Summary:

Intended Effect:

How to Verify:

Side Effects:

Documentation:

Reviewer Suggestions:

stan-buildbot commented Jun 2, 2015

syclik commented Jun 2, 2015

stan-buildbot commented Jun 3, 2015

syclik commented Jun 3, 2015

syclik Jun 3, 2015

Choose a reason for hiding this comment

rtrangucci Jun 3, 2015

Choose a reason for hiding this comment

syclik commented Jun 4, 2015

syclik commented Jun 4, 2015

syclik commented Jun 4, 2015

stan-buildbot commented Jun 5, 2015