Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/issue 1179 exponential lower bound check #1469

Merged
merged 8 commits into from
Jun 5, 2015
Merged

Bugfix/issue 1179 exponential lower bound check #1469

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
63271b6
Merge branch 'develop' of https://github.com/stan-dev/stan into develop
rtrangucci May 6, 2015
56035f9
Merge branch 'develop' of https://github.com/stan-dev/stan into develop
rtrangucci May 13, 2015
1df6630
Merge branch 'develop' of https://github.com/stan-dev/stan into develop
rtrangucci May 14, 2015
75bef68
Merge branch 'develop' of https://github.com/stan-dev/stan into develop
rtrangucci May 27, 2015
2b2c34b
Merge branch 'develop' of https://github.com/stan-dev/stan into develop
rtrangucci May 30, 2015
8dd47da
b b/i-1179 added check_nonnegative call on y
rtrangucci Jun 1, 2015
01a281d
b b/i-1179 rm tabs
rtrangucci Jun 1, 2015
1b90a57
b f/i-1179 Added valid value test and invalid value test
rtrangucci Jun 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/stan/math/prim/scal/prob/exponential_log.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ namespace stan {

T_partials_return logp(0.0);
check_not_nan(function, "Random variable", y);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this check -- it's covered by check_nonnegative

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

check_nonnegative(function, "Random variable", y);
check_positive_finite(function, "Inverse scale parameter", beta);
check_consistent_sizes(function,
"Random variable", y,
Expand Down
2 changes: 2 additions & 0 deletions src/test/prob/exponential/exponential_test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ class AgradDistributionsExponential : public AgradDistributionTest {
void invalid_values(vector<size_t>& index,
vector<double>& value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test on the boundary where y = 0.

// y
index.push_back(0U);
value.push_back(-10.0);

// beta
index.push_back(1U);
Expand Down