Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using submodules to track internal dependencies #22

Closed
leonardt opened this issue Jul 6, 2017 · 1 comment
Closed

Using submodules to track internal dependencies #22

leonardt opened this issue Jul 6, 2017 · 1 comment

Comments

@leonardt
Copy link
Contributor

leonardt commented Jul 6, 2017

Requested by @cdonovick

@jameshegarty, @phanrahan, and I had discussed using submodules. Our main concern was that they would require an explicit PR to bump the submodule commit whenever a repo pushed changes to master. If the person responsible for initiating this PR did not do it, the flow could be silently broken (that is, if they had bumped the submodule commit, we would've seen the flow break). In our current model, the nightly run would catch an offending master branch that has broken the flow, so if we have a silent breakage, at least it only lasts less than 24 hours.

Using submodules could work, but I believe it would require that we institute and enforce a policy that any changes to a master branch be accompanied by a PR to bump the submodule commit in the CGRAFlow repo.

I'd be open to hearing other solutions that prevent the flow from being broken silently.

@cdonovick
Copy link
Contributor

I had forgotten about the whole not being able to always point to HEAD in a submodule so I wan to retract that request. We could potentially use subtrees https://github.com/apenwarr/git-subtree/

@leonardt leonardt closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants