Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mem::operator< broken #244

Closed
bchurchill opened this issue Jul 29, 2018 · 1 comment
Closed

Mem::operator< broken #244

bchurchill opened this issue Jul 29, 2018 · 1 comment
Assignees
@bchurchill
Labels
bug

Comments

@bchurchill
Copy link
Member

Class Mem has operator< which is used for inserts into various data structures, like sets and maps. However, there exist objects a and b of class Mem where neither a < b, b < a, nor a == b. This happens when there's a memory reference like (%rdi) of size 8 and another (%rdi) of size 16. The parent class, Operand, has a correct operator< that works in all situations. The fix should be to just remove Mem's copy of this operator.
@bchurchill bchurchill added the bug label Jul 29, 2018
@bchurchill bchurchill self-assigned this Jul 29, 2018
@bchurchill
Copy link
Member Author

Fixed in 505ab5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bchurchill bchurchill

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bchurchill