restore missing timestamp #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off pulling this: I have to recheck if the higher volume of log output is causing OBD PIDs to be skipped during the loop. |
|
Ok, go ahead, no problems with this PR. |
|
SD data format is CSV based and includes a timestamp at first element for all lines. |
|
Perhaps in telelogger, not in datalogger (please see the linked bug report!)
I have plenty of files that are just sequences of "pid,value"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual setTimestamp method in the base FileLogger class already handles the timestamp nicely, so the fix for #91 is simply to remove the barebones implementation from the SDLogger class.
Now the first record of each block is always "PID" 0 with the timestamp.
Please consider merging, thanks.