Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/log/[file #] returns empty file #93

Closed
AndreaBorgia-Abo opened this issue May 5, 2019 · 3 comments
Closed

/api/log/[file #] returns empty file #93

AndreaBorgia-Abo opened this issue May 5, 2019 · 3 comments

Comments

@AndreaBorgia-Abo
Copy link
Contributor

As of today (commit 15a4a96), the log API in firmware_v5/datalogger returns an empty file.

There are a few files on my SD card, picking any of those will show on the serial port that the webserver handler reads so and so many bytes (and this matches the list provided by /api/list and the contents of the card) but the client will always get a zero byte file.

Tested with Firefox, wget and plain telnet.
Tested at home with USB power and in the car with the engine running ("live" API returns reasonable data).

@BevDan
Copy link

BevDan commented Jul 4, 2019

Can confirm that this issue still exists, along with the lack of timestamp PID 0 when using the latest version of the v5 datalogger. Thankfully I kept a copy from a year ago, to return to, so that most of the functions work. It seems so hard to get any answers to problems with these loggers.

@AndreaBorgia-Abo
Copy link
Contributor Author

@BevDan please see this PR for the timestamp and let me know how it goes (you may reply directly under the PR, rather than here, to keep it clean!).

I have had no time to retest the empty file issue, it seems the datalogger is not a priority for @stanleyhuangyc

@BevDan
Copy link

BevDan commented Jul 4, 2019

I will delay loading the latest version onto the logger until the empty file issue is also fixed, your fix looks very simple and straight forward to implement. The timestamps would not be such a big issue for me as I would just add my own index in lieu of the timestamp, but I need to be able to get the data from the logger over the wireless connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants