Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: refactor PennFudanPed example with new api #1167

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 9, 2022

Description

Feature Show

image
image
image

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1167 (b80bcdb) into main (cfd17ee) will increase coverage by 5.31%.
The diff coverage is 91.30%.

@@             Coverage Diff              @@
##               main    #1167      +/-   ##
============================================
+ Coverage     75.93%   81.25%   +5.31%     
============================================
  Files           206       62     -144     
  Lines         10866     6923    -3943     
  Branches        412        0     -412     
============================================
- Hits           8251     5625    -2626     
+ Misses         2468     1298    -1170     
+ Partials        147        0     -147     
Flag Coverage Δ
controller ?
standalone 81.25% <91.30%> (+0.02%) ⬆️
unittests 81.25% <91.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/type.py 82.85% <60.00%> (-0.48%) ⬇️
client/starwhale/api/_impl/metric.py 20.68% <75.00%> (+2.83%) ⬆️
client/starwhale/core/eval/view.py 65.91% <94.11%> (+1.13%) ⬆️
client/starwhale/api/_impl/model.py 91.66% <100.00%> (-0.29%) ⬇️
client/starwhale/api/_impl/wrapper.py 89.24% <100.00%> (-0.12%) ⬇️
client/starwhale/core/eval/model.py 77.47% <100.00%> (ø)
...va/ai/starwhale/mlops/storage/fs/FileIterator.java
...n/java/ai/starwhale/mlops/common/util/TagUtil.java
...ai/starwhale/mlops/datastore/TableQueryFilter.java
...ai/starwhale/mlops/domain/job/cache/JobLoader.java
... and 140 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the example/pennfudan-refactor branch 8 times, most recently from d17e5d1 to d34af50 Compare September 11, 2022 14:13
@tianweidut tianweidut changed the title WIP example: refactor PennFudanPed example with new api example: refactor PennFudanPed example with new api Sep 11, 2022
@tianweidut tianweidut marked this pull request as ready for review September 12, 2022 14:16
@tianweidut tianweidut requested review from anda-ren and goldenxinxing and removed request for anda-ren September 12, 2022 14:16
@tianweidut tianweidut force-pushed the example/pennfudan-refactor branch 2 times, most recently from 4a42e4c to 1b20a11 Compare September 12, 2022 14:23
@tianweidut tianweidut changed the title example: refactor PennFudanPed example with new api WIP example: refactor PennFudanPed example with new api Sep 12, 2022
@tianweidut tianweidut changed the title WIP example: refactor PennFudanPed example with new api example: refactor PennFudanPed example with new api Sep 13, 2022
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit fbd46ca into star-whale:main Sep 13, 2022
@tianweidut tianweidut deleted the example/pennfudan-refactor branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants