Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataset): support annotations and data type for dataset #1130

Merged

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 6, 2022

Description

Feature Show

  • model eval
    image
    image

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Sep 6, 2022
@tianweidut tianweidut added this to In progress in Starwhale Product via automation Sep 6, 2022
@tianweidut tianweidut added this to the v0.3 milestone Sep 6, 2022
@tianweidut tianweidut force-pushed the feat/dataset-multi-annotations branch 14 times, most recently from c5e5dd1 to feb0ee3 Compare September 8, 2022 14:23
@tianweidut tianweidut changed the title WIP: feat(dataset): support annotations for dataset feat(dataset): support annotations for dataset Sep 8, 2022
@tianweidut tianweidut force-pushed the feat/dataset-multi-annotations branch 2 times, most recently from ae53612 to 41590d6 Compare September 8, 2022 14:37
@tianweidut tianweidut marked this pull request as ready for review September 8, 2022 14:37
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1130 (a9f4772) into main (5a62e1b) will increase coverage by 4.70%.
The diff coverage is 71.18%.

@@             Coverage Diff              @@
##               main    #1130      +/-   ##
============================================
+ Coverage     76.51%   81.22%   +4.70%     
============================================
  Files           202       62     -140     
  Lines         10765     6928    -3837     
  Branches        410        0     -410     
============================================
- Hits           8237     5627    -2610     
+ Misses         2380     1301    -1079     
+ Partials        148        0     -148     
Flag Coverage Δ
controller ?
standalone 81.22% <71.18%> (-0.62%) ⬇️
unittests 81.22% <71.18%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/data_store.py 95.99% <ø> (-0.02%) ⬇️
client/starwhale/api/_impl/dataset/__init__.py 100.00% <ø> (ø)
client/starwhale/api/dataset.py 100.00% <ø> (ø)
client/starwhale/core/job/model.py 96.66% <ø> (-0.06%) ⬇️
client/starwhale/api/_impl/metric.py 17.85% <9.52%> (-3.20%) ⬇️
client/starwhale/base/mixin.py 93.10% <50.00%> (-6.90%) ⬇️
client/starwhale/utils/flatten.py 13.04% <50.00%> (-41.51%) ⬇️
client/starwhale/core/dataset/type.py 83.33% <67.24%> (-14.50%) ⬇️
client/starwhale/api/_impl/model.py 91.95% <88.46%> (+3.66%) ⬆️
client/starwhale/api/_impl/dataset/builder.py 84.69% <90.32%> (+0.93%) ⬆️
... and 145 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the feat/dataset-multi-annotations branch 3 times, most recently from 9e04cc5 to 060e487 Compare September 9, 2022 02:00
@tianweidut tianweidut changed the title feat(dataset): support annotations for dataset feat(dataset): support annotations and data type for dataset Sep 9, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starwhale Product automation moved this from In progress to Reviewer approved Sep 13, 2022
@goldenxinxing goldenxinxing merged commit 5547127 into star-whale:main Sep 13, 2022
Starwhale Product automation moved this from Reviewer approved to Done Sep 13, 2022
@tianweidut tianweidut deleted the feat/dataset-multi-annotations branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants