Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag a version #23

Open
KJLJon opened this issue Dec 12, 2017 · 2 comments
Open

tag a version #23

KJLJon opened this issue Dec 12, 2017 · 2 comments

Comments

@KJLJon
Copy link
Contributor

KJLJon commented Dec 12, 2017

I think a version should be tagged so it will be easier to install via composer. I recommend following symver

I am open to either one of these versions (depending on what your thoughts of the stability of the package is):

  • 0.1.0 - if you think there still might be major changed / API changes
  • 1.0.0 - if you are are pretty set on the packages public API.
@starekrow
Copy link
Owner

Argeed. If we can get the KDF stuff handled quickly (viz. #5 and #11) and bump CryptoKey to k1|..., I’d say version 1.0.0. I’d accept a PR for 0.1.0 at any time; I’m actually reasonably pleased with the API as it stands.

@KJLJon
Copy link
Contributor Author

KJLJon commented Dec 12, 2017

I am almost done with #5, and was going to try to work on #11 at the same time (in the PR) so the key only has to be bumped up to k1 instead of k1 and k2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants