-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a julia module #1030
feat: Add a julia module #1030
Conversation
Co-Authored-By: Thomas O'Donnell <andytom@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy cow the number of things we need to change to add a new module is getting high. We should probably make a list somewhere...
As an aside, do you think the "therefore" emoji (∴) might be an appropriate default symbol? It's not exactly the julia logo, but it seems to be used in at least some places that are common (e.g. it's pretty similar to the favicon used on the Julia website)
I think so.
That's nice! |
It seems that julia uses |
It's sound good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# ~/.config/starship.toml | ||
|
||
[julia] | ||
symbol = "👸 " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this example may not be compliant with Julia's community standards:
do not sexualize the term "Julia" or any other aspects of the project. While "Julia" is a female name in many parts of the world, the programming language is not a person and does not have a gender.
I'd suggest using something different, e.g. "Mathematical Bold Capital J" (U+1D409):
symbol = "𝐉 "
or "Mathematical Sans-serif Bold Small J" (U+1D5F7), which looks similar to the j in Julia's logo:
symbol = "𝗷 "
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, it would probably be best if we changed it.
I like both your suggestions, @waldyrious. Another option if the "Therefore" symbol, present in the Julia logotype and favicon: ∴
or ஃ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The therefore symbol is actually already the default :) if I understood the code correctly, this was an example of customizing the symbol. However, the second symbol you listed is an even better match to the Julia logo! I'd suggest replacing the current default with it and using one of the J symbols I proposed as an example of customization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The therefore symbol is actually already the default :)
Ah right. My bad. 🤦♂
This is what happens when I swoop into issues without reading the context. 😅
However, the second symbol you listed is an even better match to the Julia logo! I'd suggest replacing the current default with it and using one of the J symbols I proposed as an example of customization.
Sounds good to me. 👍
Would you be open to creating a PR for the change, Waldir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh.. I didn't know https://julialang.org/community/standards/ 🙇
I will fix this as soon as possible.
* add a julia module * Update docs/config/README.md Co-Authored-By: Thomas O'Donnell <andytom@users.noreply.github.com> * fix based on starship#1030 (review) Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
Description
Motivation and Context
Closes #
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: