Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authority for setting label #977

Open
mmurooka opened this issue Oct 18, 2016 · 8 comments
Open

Authority for setting label #977

mmurooka opened this issue Oct 18, 2016 · 8 comments

Comments

@mmurooka
Copy link
Member

@k-okada ,
In jsk-ros-pkg/jsk_common, we can set label for PR even though we cannot merge PR (f.g. jsk-ros-pkg/jsk_recognition#1904 ).
Is it possible to give us such authority for this repository too?

I'd like to set label to the following PRs: #976, #974, #973 .

@k-okada
Copy link
Member

k-okada commented Oct 18, 2016

changed setting, please check this

◉ Kei Okada

2016-10-18 12:21 GMT+09:00 Masaki Murooka notifications@github.com:

@k-okada https://github.com/k-okada ,
In jsk-ros-pkg/jsk_common, we can set label for PR even though we cannot
merge PR (f.g. jsk-ros-pkg/jsk_recognition#1904
jsk-ros-pkg/jsk_recognition#1904 ).
Is it possible to give us such authority for this repository too?

I'd like to set label to the following PRs: #976
#976, #974
#974, #973
#973 .


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#977, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAeG3GTTI1v0Yb9E7pfR3LJ0IVL_O25Fks5q1DtEgaJpZM4KZVgH
.

@mmurooka
Copy link
Member Author

Thank you. It worked.

@snozawa
Copy link
Contributor

snozawa commented Oct 25, 2016

Authorityの設定はどこみたらよかったでしょうか?
私のauthority権限がかわってるかもしれません(mergeボタンのところなどにnot authorizedとでてきます)

@snozawa snozawa reopened this Oct 25, 2016
@snozawa
Copy link
Contributor

snozawa commented Oct 25, 2016

今みたらauthorizedされてました。

@snozawa snozawa closed this as completed Oct 25, 2016
@k-okada
Copy link
Member

k-okada commented Oct 25, 2016

直ったかな

2016年10月25日火曜日、Shunichi Nozawanotifications@github.comさんは書きました:

Reopened #977 #977.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#977 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeG3MfFxfHKaKu38xwgxj-4dIFSycd5ks5q3YJ_gaJpZM4KZVgH
.

◉ Kei Okada

@snozawa
Copy link
Contributor

snozawa commented Oct 25, 2016

作業ありがとうございます。

昨日午後くらいに一瞬なおったのですが、
#981
#983
をみると、mergeボタンのところに

- Review required
At least one approved review is required by reviewers with write access.
- All checks have passed
1 successful check
Details
Required
continuous-integration/travis-ci/pr — The Travis CI build passed
- Merging is blocked
Merging can be performed automatically with one approved review. 

とでてました。
mergeがblockされてるとでているようでした。
こちらも何か変更がありましたでしょうか。

@mmurooka
Copy link
Member Author

@k-okada
ラベルをつける権限とレビューを必須にすることは独立に設定できて,
今回はそれが同時に変更されたという理解であっていますか.

@snozawa
Copy link
Contributor

snozawa commented Oct 27, 2016

@k-okada さん
運用方針に変更が加えるときには、変更内容一式をアナウンスしていただけると助かります。
権限変更などgithub上での設定をかえるときにもissueをたてる、というのはいかがでしょうか。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants