Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtm-ros-robot-interface.l] temporary fix controller action name #970

Closed

Conversation

YoheiKakiuchi
Copy link
Member

relate to jsk-ros-pkg/jsk_pr2eus#237
default joint_trajectory_action method should be changed to follow_joint_trajectory_action.

@YuOhara
Copy link
Contributor

YuOhara commented Oct 10, 2016

I want it merged ASAP.

(@otsubo
You need to include this change if you update hrp2 tomorrow.)

@YuOhara
Copy link
Contributor

YuOhara commented Oct 10, 2016

Update is scheduled at 25th (not tomorrow), so this is not anything urgent.

@k-okada
Copy link
Member

k-okada commented Oct 13, 2016

should we change (cons :controller-action "fullbody_controller/joint_trajectory_action") to (cons :controller-action "fullbody_controller/follow_joint_trajectory_action") at https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/237/files#diff-15f6920b924513f6027d36b361f85bbdR793, instead of changing in sub-class code?

@YoheiKakiuchi
Copy link
Member Author

Topic name, 'follow_joint_trajectory_action', is defined in HrpsysSeqStateROSBridge.
So, I think to fix it in rtmros_common.

Case A:
Change name of action in HrpsysSeqStateROSBridge
Because pr2_controller_msgs is obsolated. #971

Case B:
Change default name of action in robot-interface.l
this is simple, if there is no other problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants