-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Possibly outdated chromedp causes unmarshaling error when scraping with CDP (unknown PrivateNetworkRequestPolicy value) #3733
Comments
yeah, it's possible that only certain content triggers it, or that some users decide that this technical stuff is too complex already and they'll just wait until they can pull from stashdb. |
@its-josh4 Would you be able to update chromedp in #4107 to fix this issue? Just a bump to v0.7.8 seems like it would do the job, although the latest v0.9.2 would of course be the best if you're willing to make any necessary changes. |
@DingDongSoLong4 done |
* Update a number of dependencies (incl. CVE fixes) Includes some dependencies that were upgraded in #4106 as well as a few more dependencies. Some deps that have been upgraded had CVEs. Notably, upgrades deprecated dependencies such as: - `github.com/go-chi/chi` (replaced with `/v5`) - `github.com/gofrs/uuid` (replaced with `/v5`) - `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics) * Upgraded a few more deps * lint * reverted yaml library to v2 * remove unnecessary mod replace * Update chromedp Fixes #3733
* Update a number of dependencies (incl. CVE fixes) Includes some dependencies that were upgraded in stashapp#4106 as well as a few more dependencies. Some deps that have been upgraded had CVEs. Notably, upgrades deprecated dependencies such as: - `github.com/go-chi/chi` (replaced with `/v5`) - `github.com/gofrs/uuid` (replaced with `/v5`) - `github.com/hashicorp/golang-lru` (replaced with `/v2` which uses generics) * Upgraded a few more deps * lint * reverted yaml library to v2 * remove unnecessary mod replace * Update chromedp Fixes stashapp#3733
Describe the bug
Can't use CDP with some scrapers on macOS
To Reproduce
Steps to reproduce the behavior:
ERROR: could not unmarshal event: unknown PrivateNetworkRequestPolicy value
are loggedExpected behavior
The scenes can be parsed normally and no extraneous messages are added to the log
Stash Version: (from Settings -> About): 0.20.2 (build hash e685f80)
Desktop (please complete the following information):
Smartphone (please complete the following information):
No smartphone involved
Additional context
Tried with CDP based on Brave, Chromium and Chrome (all newest versions)
After looking up the error message, it appears that is related to old chromedp not being able to handle a new value for the PrivateNetworkRequestPolicy, but these changes appear to be at least 8 months old. And not seeing this issue being reported here before makes me suspect it is the Mac build of Stash which is made with an outdated version of chromedp. It could be that it is cross compiled and this part is not properly tested by the people preparing the builds.
The text was updated successfully, but these errors were encountered: