Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate i18n into UI elements #1471

Merged
merged 29 commits into from
Jun 14, 2021
Merged

Incorporate i18n into UI elements #1471

merged 29 commits into from
Jun 14, 2021

Conversation

Still34
Copy link
Contributor

@Still34 Still34 commented Jun 2, 2021 •
edited by WithoutPants
Loading

Summary

This PR aims to incorporate the existing i18n implementation deeper into the UI elements, bringing i18n to the entire frontend. As a proof-of-concept, the zh-TW localization strings are also included in this PR.

To-do

Elements with i18n implemented:

  • Performer (incl. actions, bio, etc.)
  • Tags
  • Button actions
  • Modal dialogs
  • Settings
    • General
    • Interface
    • Tasks
    • DLNA
    • Tools
    • Scrapers
    • Plugins
    • Logs
    • About
  • Scenes (incl. editing)
  • Movies (incl. editing)
  • Markers

Resolves #566

@Still34 Still34 changed the title Implement i18n into UI elements Incorporate i18n into UI elements Jun 2, 2021
@Still34 Still34 force-pushed the i18n/impl-i18n-and-zh-tw branch 2 times, most recently from 6805d6a to e3db6af Compare June 3, 2021 16:28
Still34 added 14 commits June 4, 2021 18:24
@Still34
Update zh-tw string table (till 975343d)
0ba1ec1
@Still34
Prepare localization table
d577823
@Still34
Implement i18n for Performers & Tags
737c0f5
@Still34
Add "add" action strings
9fd9584
@Still34
Replace triple dots with ellipsis
99bb066
@Still34
Revert performer_bio refactor
290843c 
The refactor will cause breaking changes to existing data types, reverting.
@Still34
Use Lodash merge for deep merging language JSONs
ba491ed 
The original implementation does not properly merge language files, causing unexpected localization string fallback behavior.
@Still34
Localize pagination strings
f38ab38
@Still34
Use Field name value as null id fallback
0617a1f 
...otherwise FormattedMessage is gonna throw when the ID is null
@Still34
Use localized "Path" string for all instances
ee7dc34
@Still34
Localize the "Interface" tab under settings
029dc6e
@Still34
Fix linting errors
cf11f5b
@Still34
Update more buttons
597da79
@Still34
Localize scene & performer cards
a0148ff
@Still34 Still34 marked this pull request as ready for review June 5, 2021 15:02
@WithoutPants WithoutPants added this to the Version 0.8.0 milestone Jun 8, 2021
@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Jun 8, 2021
WithoutPants
WithoutPants requested changes Jun 8, 2021
View reviewed changes
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MovieDetailsPanel is missing internationalisation.

Apart from the review comments, this appears to test ok.

ui/v2.5/src/locales/en-US.json Outdated Show resolved Hide resolved
ui/v2.5/src/utils/field.tsx Outdated Show resolved Hide resolved
ui/v2.5/src/utils/field.tsx Outdated Show resolved Hide resolved
ui/v2.5/src/utils/field.tsx Outdated Show resolved Hide resolved
ui/v2.5/src/utils/field.tsx Outdated Show resolved Hide resolved
ui/v2.5/src/components/Performers/PerformerDetails/PerformerDetailsPanel.tsx Outdated Show resolved Hide resolved
ui/v2.5/src/components/Performers/PerformerDetails/PerformerDetailsPanel.tsx Outdated Show resolved Hide resolved
@Still34 Still34 requested a review from WithoutPants June 8, 2021 12:18
@WithoutPants
Copy link
Collaborator

I've added the following to en-GB. This can be added to zh-TW json file in another PR:

"plugins": {
      "hooks": "Hooks",
      "triggers_on": "Triggers on"    
}

@WithoutPants WithoutPants merged commit 3ae187e into stashapp:develop Jun 14, 2021
@PhilippKeil PhilippKeil mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kermieisinthehouse kermieisinthehouse kermieisinthehouse left review comments

@WithoutPants WithoutPants WithoutPants approved these changes

Assignees
No one assigned
Labels
feature Pull requests that add a new feature
Projects
None yet
Milestone
Version 0.8.0
Development

Successfully merging this pull request may close these issues.

[Feature] Wrap all text in react-intl for localization
3 participants
@Still34 @WithoutPants @kermieisinthehouse