Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation (fr-FR) #1967

Merged
merged 7 commits into from
Nov 8, 2021

Conversation

Frix-416
Copy link
Contributor

@Frix-416 Frix-416 commented Nov 7, 2021

Added a French translation for Stash.
It is certainly not perfect since French is a gendered language and Stash was not coded with that in mind.
Sentences construction can be a little spooky sometimes but I'm quite satisfied with the result.
Hope it help.

* almost complete french translation
* necessary files modification for the app to compile with french translation included
* rephrased certain sentences so that they look better in context.
* removed the Setup section in the translation since it cannot be displayed at the moment (I believe)
@kermieisinthehouse kermieisinthehouse added documentation Instructions and support material ui Issues related to UI labels Nov 7, 2021
@kermieisinthehouse kermieisinthehouse added this to the Version 0.11.0 milestone Nov 7, 2021
some spelling errors
some more spelling errors
@Belleyy
Copy link
Contributor

Belleyy commented Nov 7, 2021

J'ai peut être louper des trucs, bien joué en tout cas 👍
For EN: Maybe i miss things, good job anyways 👍

@Frix-416
Copy link
Contributor Author

Frix-416 commented Nov 7, 2021

Merci pour la review :)
Thanks for the review :)

Copy link
Collaborator

@kermieisinthehouse kermieisinthehouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't opine on the language, but the JSON is formed correctly and the locale is configured correctly.

@WithoutPants WithoutPants merged commit ffc8043 into stashapp:develop Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Instructions and support material ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants