Prevent invalid date tag in video file from aborting scan #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks ok and it seems to run ok ( I don't have a sample file to trigger the malformed date issue ) |
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Give more context when ffprobe fails * Suppress JSONTime unmarshal error * Tidy scan logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #731
Some files have a malformed date tag in their metadata. This would cause the ffprobe unmarshal to fail. I have changed
JSONTimeto log a warning instead of returning an error when unmarshalling a malformed date. In addition, I've improved the logging to provide the filename for ffprobe errors, and tidied some of the scan logging to be cleaner and less verbose.