Fix: Password Reset validation messages are not shown #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“Forgot password” uses a custom validation bag: https://github.com/statamic/cms/blob/e923a27b35d8711337f422bcd7a64cdbf621f5b4/src/Auth/SendsPasswordResetEmails.php#L64 “Forgot” and “Reset” password views show validation error above fields while in CP error messages are shown below.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
Password Reset validation messages are not shown after an invalid submit.
How to Reproduce
Try to submit the "Forgot Your Password" form without fill the email field.
Environment
Statamic 3.0.16 Pro
Laravel 8.9.0
PHP 7.4.9
No addons installed
What I have fixed
“Forgot password” view retrieve errors from the "default" validation bag but it uses a custom one:
cms/src/Auth/SendsPasswordResetEmails.php
Line 64 in e923a27
UI: “Forgot” and “Reset” password views display validation errors above fields while in CP error messages are displayed below.