Fix localizable grid in stacked mode #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurperton
requested review from
jackmcdade
and removed request for
jasonvarga
arthurperton
requested review from
jackmcdade and
jesseleite
and removed request for
jackmcdade
|
Hi guys, I wonder why this one has been left aside. Since the fix is so short and straightforward. Is this also something that you'd rather see solved on the backend maybe? |
jasonvarga
approved these changes
May 5, 2021
There was a problem hiding this comment.
Sorry for the delay.
My hesitancy was because it works differently from Replicators. You get the little speech bubble icons in Grid, but not in Replicator.
Looks like Replicator has its own Field.vue, where Grid just uses the standard one.
This fix is probably fine for now. I don't think we need to introduce a new component and complexity just to get rid of the icon.
|
Thanks for clearing that up. I missed that difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3498.
Since only top-level fields can be localizable, the
stacked-rowoverrides the grid subfield's localizable setting in the config just before handing it to thepublish-field.