Suffix tricky field names in Blueprint and Fieldset builders

[arthurperton]

This suffixes fields names like assets, date and link so they become assets_field, date_field and link_field to avoid problems like #3687.

[jasonvarga]

Why don't we just do this for all fields?

[jackmcdade]

Sure, we could do it for all of em – I just like some of the default field names (like text, markdown, etc) – not a big deal. Consistency is probably a better experience.

[arthurperton]

So to be clear I'm just slapping a __('Field') at the end of it. That word is in the translation files. Hope the word order works in all languages 🤞🏻

[jasonvarga]

It's just a placeholder. I don't think the word order matters too much there. 👍

Like I mentioned once before, I think that most of the time if you're using the default placeholder field name as the real field name, more than likely you're just slamming fields into a blueprint quickly to reproduce a bug. If you're building a real blueprint you'd probably give the field name more than a muscle memory's worth of thought. And then like Jack said, consistency is good so only adding "Field" to 3 fields might be weirder.

Addressing issues like #3687 is probably more important.

Just my opinion though!

[arthurperton]

I agree. So this is a good step towards preventing issues like #3687. At least by this PR you're not set off on the wrong foot anymore by 'dangerous' examples. We could also consider adding assets to the list of reserved words in the docs and Statamic\Http\Controllers\CP\Fields\FieldsController->blueprint().