Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore null image in Bard #5864

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Ignore null image in Bard #5864

merged 2 commits into from
Apr 20, 2022

Conversation

fdabek1
Copy link
Contributor

@fdabek1 fdabek1 commented Apr 19, 2022 •
edited
Loading

It seems that the Bard inline image component tries to load null images before they are set. This is related to the following issues: #5860 #5861

This PR makes the image not attempt to be loaded if the id is null.

Closes #5860

@fdabek1 fdabek1 mentioned this pull request Apr 19, 2022
Closed
@edalzell
Copy link
Contributor

If you add Closes #5860 and the other one, they'll be closed when this PR is merged.

@jasonvarga
Copy link
Member

Thanks but in my testing, this change didn't fix anything. id was not null, it was an empty string, so it still did the request.

I've updated the code.

@jasonvarga jasonvarga merged commit b67c4b2 into statamic:3.3 Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null XHR causing Asset lookup to fail
3 participants
@fdabek1 @edalzell @jasonvarga