Runtime: resets stack state #6140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes statamic/ssg#98 by clearing the stack contents when the main Antlers render method is invoked.
To validate the fix, use stacks in the site's layout, and push to it from a template that is rendered multiple times. Once you run the
ssg:generatecommand, you will find that the pushed contents are rendered multiple times on subsequent pages. In addition to validating against an SSG site, the provided test case will also fail when moving it to the base branch 👍There exists a test case already to ensure this change does not break using stacks from partials: statamic/ssg#98