Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft entries with nocache tag in template show placeholder in Live Preview #6725

Closed
edalzell opened this issue Sep 15, 2022 · 3 comments · Fixed by #6838
Closed

Draft entries with nocache tag in template show placeholder in Live Preview #6725

edalzell opened this issue Sep 15, 2022 · 3 comments · Fixed by #6838

Comments

@edalzell
Copy link
Contributor

Bug description

Draft entries with nocache tag in template show the no cache placeholder in Live Preview

How to reproduce

  1. Create an entry
  2. In that entry's template, use the nocache tag.
  3. Make that entry draft
  4. Use Live Preview

Logs

No response

Environment

Environment
Application Name: Statamic
Laravel Version: 9.30.1
PHP Version: 8.1.10
Composer Version: 2.4.1
Environment: local
Debug Mode: ENABLED
URL: placeholder.test
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: statamic
Database: mysql
Logs: stack / single
Mail: smtp
Queue: sync
Session: file

Statamic
Addons: 0
Antlers: regex
Version: 3.3.36 PRO

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

runtime (new)

Additional details

No response

@edalzell
Copy link
Contributor Author

Proof of concept fix: #6724

@jasonvarga
Copy link
Member

Related: #6543

@edalzell
Copy link
Contributor Author

Interestingly, it seems like setting the entry to published (in middleware) means the replacement happens.

In my Review addon I have this in my Token Handler:
CleanShot 2022-09-21 at 11 07 06@2x

And the review links work perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants