Fix nocache placeholder appearing in responses #6838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
The extra conditions weren't really necessary. I've just made it so it'll just make the replacements in a simple always (except for redirects).else.
It's a bit unfortunate that the method is called replaceInCachedResponse even though now it's technically not "the cached response". It's just ... the response. Oh well. Better than a breaking change.
Thanks!
|
Unfortunately, throwing a Can you reproduce this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6725 and fixes #6543.
If the response is not cached (because it is a 404 or a draft viewed in Live Preview) the placeholders are now still replaced with the actual content, to get valid output.