Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry revisions publish button visible when user doesn't have permission to publish #6911

Closed
byron-roots opened this issue Oct 18, 2022 · 2 comments · Fixed by #7168
Closed

Comments

@byron-roots
Copy link

Bug description

When revision are enabled and editing an entry where the user doesn't have permission to publish that entry, the publish button is still visible.

When trying to publish the entry, a 403 error occurs so the entry isn't published, but it is a bit confusing.

How to reproduce

  1. Install Statamic
  2. Create an entry with revisions
  3. Set up a user without publish permissions
  4. Edit an entry, publish button should be visible

Logs

No response

Environment

Statamic 3.3.44 Pro
Laravel 8.83.25
PHP 8.1.11
aryehraber/statamic-logbook 2.1.0
aryehraber/statamic-splash 1.1.0
jacksleight/statamic-bard-mutator 1.1.2
jacksleight/statamic-bard-texstyle 1.0.3
rootstudio/cache-primer 0.5
rootstudio/events-manager dev-profile-events
rootstudio/perch-importer 0.1
statamic/collaboration 0.4.0

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

regex (default)

Additional details

No response

@byron-roots
Copy link
Author

Just to add to this, when selecting the publish button, The option to create a revision should still be available as this isn't restricted by the publish permissions

@mmodler
Copy link
Contributor

mmodler commented Nov 22, 2022

+1

One of our customers just complained about this, too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants